electron
/
pulseview
mirror of git://sigrok.org/pulseview
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

Fix warnings coming up with clang 17 

Also with -Wunqualified-std-cast-call that's enabled on github's macos-14-arm64 runner.
This commit is contained in:
Soeren Apel 2024-08-30 21:27:30 +02:00
parent 3cb3859dfc
commit f48be9a602
4 changed files with 5 additions and 7 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
CMakeLists.txt
View File

@ -563,7 +563,7 @@ endif()
add_definitions(-DQT_NO_KEYWORDS) add_definitions(-DQT_NO_KEYWORDS)
add_definitions(-D__STDC_LIMIT_MACROS) add_definitions(-D__STDC_LIMIT_MACROS)
add_definitions(-Wall -Wextra) add_definitions(-Wall -Wextra -Wunqualified-std-cast-call)
add_definitions(${REQUIRED_STD_CXX_FLAGS}) add_definitions(${REQUIRED_STD_CXX_FLAGS})
add_definitions(-DBOOST_MATH_DISABLE_FLOAT128=1) add_definitions(-DBOOST_MATH_DISABLE_FLOAT128=1)

4
pv/data/decode/decoder.cpp
View File

@ -86,10 +86,6 @@ Decoder::Decoder(const srd_decoder *const dec, uint8_t stack_level) :
} }
// Query the annotation rows and reference them by the classes that use them // Query the annotation rows and reference them by the classes that use them
uint32_t row_count = 0;
for (const GSList *rl = srd_decoder_->annotation_rows; rl; rl = rl->next)
row_count++;
i = 0; i = 0;
for (const GSList *rl = srd_decoder_->annotation_rows; rl; rl = rl->next) { for (const GSList *rl = srd_decoder_->annotation_rows; rl; rl = rl->next) {
const srd_decoder_annotation_row *const srd_row = (srd_decoder_annotation_row *)rl->data; const srd_decoder_annotation_row *const srd_row = (srd_decoder_annotation_row *)rl->data;

2
pv/session.cpp
View File

@ -607,7 +607,7 @@ void Session::set_device(shared_ptr<devices::Device> device)
signals_changed(); signals_changed();
device_ = move(device); device_ = std::move(device);
try { try {
device_->open(); device_->open();

4
pv/views/trace/analogsignal.cpp
View File

@ -48,11 +48,13 @@
#include <libsigrokcxx/libsigrokcxx.hpp> #include <libsigrokcxx/libsigrokcxx.hpp>
using std::abs;
using std::deque; using std::deque;
using std::div; using std::div;
using std::div_t; using std::div_t;
// Note that "using std::isnan;" is _not_ put here since that would break // Note that "using std::isnan;" is _not_ put here since that would break
// compilation on some platforms. Use "std::isnan()" instead in checks below. // compilation on some platforms. Use "std::isnan()" instead in checks below.
using std::fabs;
using std::max; using std::max;
using std::make_pair; using std::make_pair;
using std::min; using std::min;
@ -766,7 +768,7 @@ void AnalogSignal::process_next_sample_value(float x, float value)
// Interpolate values to create values for the intermediate pixels // Interpolate values to create values for the intermediate pixels
const float start_value = prev_value_at_pixel_; const float start_value = prev_value_at_pixel_;
const float end_value = value; const float end_value = value;
const int steps = fabs(pixel_pos - current_pixel_pos_); const int steps = abs(pixel_pos - current_pixel_pos_);
const double gradient = (end_value - start_value) / steps; const double gradient = (end_value - start_value) / steps;
for (int i = 0; i < steps; i++) { for (int i = 0; i < steps; i++) {
if (current_pixel_pos_ + i < 0) if (current_pixel_pos_ + i < 0)