From d8f4d040935326b0893639a473e5eb171f714c85 Mon Sep 17 00:00:00 2001 From: Jon Evans Date: Wed, 22 Feb 2023 20:13:44 -0500 Subject: [PATCH] Disable auto-refill zones We need a more advanced dirtying system for this to work out for many users, it turns out. Right now too many changes cause full zone refills which interrupt workflow. --- pcbnew/pcbnew_settings.cpp | 12 ++++++++++-- 1 file changed, 10 insertions(+), 2 deletions(-) diff --git a/pcbnew/pcbnew_settings.cpp b/pcbnew/pcbnew_settings.cpp index a522a0661f..b2a6a595b3 100644 --- a/pcbnew/pcbnew_settings.cpp +++ b/pcbnew/pcbnew_settings.cpp @@ -43,7 +43,7 @@ ///! Update the schema version whenever a migration is required -const int pcbnewSchemaVersion = 4; +const int pcbnewSchemaVersion = 5; PCBNEW_SETTINGS::PCBNEW_SETTINGS() @@ -168,7 +168,7 @@ PCBNEW_SETTINGS::PCBNEW_SETTINGS() &m_Use45DegreeLimit, false ) ); m_params.emplace_back( new PARAM( "editing.auto_fill_zones", - &m_AutoRefillZones, true ) ); + &m_AutoRefillZones, false ) ); m_params.emplace_back( new PARAM( "editing.allow_free_pads", &m_AllowFreePads, false ) ); @@ -620,6 +620,14 @@ PCBNEW_SETTINGS::PCBNEW_SETTINGS() // This is actually a migration for APP_SETTINGS_BASE::m_LibTree return migrateLibTreeWidth(); } ); + + registerMigration( 4, 5, + [&]() -> bool + { + // This default proved to be unpopular; bump it off for everyone + Set( "editing.auto_fill_zones", false ); + return true; + } ); }