electron
/
kicad
mirror of https://gitlab.com/kicad/code/kicad.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

Fix various compile warnings

This commit is contained in:
Jon Evans 2024-09-18 18:51:02 -04:00
parent 8647da613f
commit 1895ec58a0
7 changed files with 10 additions and 11 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

3
3d-viewer/3d_canvas/board_adapter.cpp
View File

@ -529,6 +529,9 @@ void BOARD_ADAPTER::InitSettings( REPORTER* aStatusReporter, REPORTER* aWarningR
zposBottom = zpos_copperTop_front + 1.0f * zpos_offset;
zposTop = zposBottom + m_nonCopperLayerThickness3DU;
break;
default:
break;
}
m_layerZcoordTop[layer_id] = zposTop;

2
kicad/dialogs/panel_kicad_launcher.h
View File

@ -38,8 +38,6 @@ private:
void onThemeChanged( wxSysColourChangedEvent& aEvent );
void onLauncherButtonClick( wxCommandEvent& aEvent );
private:
TOOL_MANAGER* m_toolManager;
KICAD_MANAGER_FRAME* m_frame;
};

4
pcbnew/dialogs/dialog_export_odbpp.cpp
View File

@ -90,8 +90,6 @@ bool DIALOG_EXPORT_ODBPP::Init()
{
PCBNEW_SETTINGS* cfg = Pgm().GetSettingsManager().GetAppSettings<PCBNEW_SETTINGS>();
BOARD* board = m_parent->GetBoard();
m_choiceUnits->SetSelection( cfg->m_ExportODBPP.units );
m_precision->SetValue( cfg->m_ExportODBPP.precision );
m_cbCompress->SetValue( cfg->m_ExportODBPP.compress );
@ -109,4 +107,4 @@ bool DIALOG_EXPORT_ODBPP::TransferDataFromWindow()
cfg->m_ExportODBPP.compress = m_cbCompress->GetValue();
return true;
}
}

1
pcbnew/pcb_io/geda/pcb_io_geda.cpp
View File

@ -321,7 +321,6 @@ FOOTPRINT* GPCB_FPL_CACHE::parseFOOTPRINT( LINE_READER* aLineReader )
// GPCB unit = 0.01 mils and Pcbnew 0.1.
double conv_unit = NEW_GPCB_UNIT_CONV;
VECTOR2I textPos;
wxString msg;
wxArrayString parameters;
std::unique_ptr<FOOTPRINT> footprint = std::make_unique<FOOTPRINT>( nullptr );

4
pcbnew/pcb_io/kicad_sexpr/pcb_io_kicad_sexpr_parser.cpp
View File

@ -5456,8 +5456,7 @@ void PCB_IO_KICAD_SEXPR_PARSER::parseGROUP( BOARD_ITEM* aParent )
wxCHECK_RET( CurTok() == T_group,
wxT( "Cannot parse " ) + GetTokenString( CurTok() ) + wxT( " as PCB_GROUP." ) );
VECTOR2I pt;
T token;
T token;
m_groupInfos.push_back( GROUP_INFO() );
GROUP_INFO& groupInfo = m_groupInfos.back();
@ -6004,7 +6003,6 @@ ZONE* PCB_IO_KICAD_SEXPR_PARSER::parseZONE( BOARD_ITEM_CONTAINER* aParent )
ZONE_BORDER_DISPLAY_STYLE hatchStyle = ZONE_BORDER_DISPLAY_STYLE::NO_HATCH;
int hatchPitch = ZONE::GetDefaultHatchPitch();
VECTOR2I pt;
T token;
int tmp;
wxString netnameFromfile; // the zone net name find in file

5
pcbnew/pcb_io/odbpp/odb_util.cpp
View File

@ -183,7 +183,10 @@ VECTOR2I GetShapePosition( const PCB_SHAPE& aShape )
case SHAPE_T::POLY:
case SHAPE_T::BEZIER:
case SHAPE_T::SEGMENT:
case SHAPE_T::ARC: pos = aShape.GetPosition(); break;
case SHAPE_T::ARC:
case SHAPE_T::UNDEFINED:
pos = aShape.GetPosition();
break;
}
return pos;

2
pcbnew/tools/pcb_point_editor.cpp
View File

@ -845,7 +845,7 @@ void PCB_POINT_EDITOR::editArcEndpointKeepTangent( PCB_SHAPE* aArc, const VECTOR
v2 = p2 - aCenter;
v3 = p3 - aCenter;
VECTOR2D u1, u2, u3;
VECTOR2D u1, u2;
// A point cannot be both the center and on the arc.
if( ( v1.EuclideanNorm() == 0 ) || ( v2.EuclideanNorm() == 0 ) )